Fix legend icon not rendering correctly due to wrong scaled dpr metric#110
Merged
PierreRaybaut merged 1 commit intoJun 27, 2026
Merged
Conversation
Collaborator
|
Thanks a lot @Adrian-B-Moreira for the feedback and for the fix! |
Collaborator
|
Hey @Adrian-B-Moreira, we already have a few fixes since v0.16.2. If you want, we can release it quickly. Unless you may have other things to fix or report? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix QwtNullPaintDevice.metric() returning the wrong value for PdmDevicePixelRatioScaled, which caused legend icons to collapse to a degenerate size.
This is similar to #104, but with different causes.
Qt stores the device pixel ratio as a fixed-point integer scaled by QPaintDevice::devicePixelRatioFScale() (which is 0x10000 = 65536). This is how Qt represents a fractional DPR (e.g. 1.25, 1.5, 2.0) while keeping metric()'s return type as int.
So returning 1 for PdmDevicePixelRatioScaled means DPR interpreted as 1/65536 ≈ 0.0000153 → collapsed.
This also prevents the "Device has no metric information" warning.
Before the fix:
After the fix: